🌱 generalize tools Dockerfiles for arm64, ppc64le linux builds #1992
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/cc @DirectXMan12 @Adirio |
| - 'GOOS=${_GOOS}' | ||
| - 'GOARCH=${_GOARCH}' | ||
| images: ["gcr.io/kubebuilder/thirdparty-${_GOOS}:1.20.2"] | ||
| - name: "gcr.io/kubebuilder/thirdparty-${_GOOS}-${_GOARCH}:${_KUBERNETES_VERSION}" |
There was a problem hiding this comment.
should we keep something around that cross-tags this to the old thirdparty-${OS} format too, so we don't confuse people? (this is a question, not a suggestion -- I can't quite convince myself either way)
There was a problem hiding this comment.
Is this image intended to be pulled/used outside of this build system? If so then I don’t think the old format should be kept around because it is now ambiguous.
EDIT: actually for v1.19 I think we can make an exception because released kubebuilder projects already use the old format.
There was a problem hiding this comment.
Edit: nevermind, we are distributing tarballs, not docker images. Docker is just used as the build environment.
| args: [ | ||
| "-h", "Content-Type:application/gzip", | ||
| "cp", | ||
| "/workspace/kubebuilder-tools-${_KUBERNETES_VERSION}-${_GOOS}-${_GOARCH}.tar.gz", |
There was a problem hiding this comment.
ditto here.
In either case, will need to update the go.kubebuilder.io shortlinks
There was a problem hiding this comment.
The tarball name format hasn't changed, and if it has it shouldn't have since it already includes os and arch.
estroz
force-pushed
the
chore/arm64-tools
branch
from
0dc0a18 to
4f928d1
Compare
build/cloudbuild_tools.yaml: update with new Dockerfile args, prettify README.md: add new arches Signed-off-by: Eric Stroczynski <[email protected]>
estroz
force-pushed
the
chore/arm64-tools
branch
from
4f928d1 to
8f5b2ab
Compare
| - `_GOARCH=arm64 _GOOS=linux` | ||
| - `_GOARCH=ppc64le _GOOS=linux` |
There was a problem hiding this comment.
Do this need to be listed somewhere else? I mean you will need to configure this list of os/arch somewhere (maybe not in code though).
There was a problem hiding this comment.
Yeah I think @DirectXMan12 needs to update these vars in gcloud.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Note: this PR also downgrades k8s version to v1.19.2 so arm64 and ppc64le builds occur for a v1.19 version. I will post a follow-up PR to upgrade the version back to v1.20.2 after this is merged.
Closes #966
Signed-off-by: Eric Stroczynski [email protected]